Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to work with new version - Typeorm not working #2

Open
panbhatt opened this issue Jun 11, 2020 · 9 comments
Open

Unable to work with new version - Typeorm not working #2

panbhatt opened this issue Jun 11, 2020 · 9 comments
Labels
good first issue Good for newcomers

Comments

@panbhatt
Copy link
Contributor

Hi Team,
this boilerplate seems not be working after we integrated TYPEORM in the project. Let me know, if i can do a pull request or create a new repository with React/TypeORM.
@Romakita
Copy link

Yes you can create Pull request :)

panbhatt added a commit to panbhatt/tsed-example-react that referenced this issue Jun 12, 2020
@panbhatt
https://github.com/TypedProject/tsed-example-react/issues/2
ea77fb9 
new things incorporated:
    1. Prettier has been introduced on the server side, so automatically it can call prettier once the git commit is invoked. 
    2. link module alias has been introduced. 
    3. Typeorm has been introduced. 
    
    
    This project is dependent on SQL Server, however can be replaced with any of the available DB type.
    THe table must contain a table called Employee with the following columns as specified in the Entity / Employee.ts
    
    on hitting the url http://localhost:3000 we can on the server side that TOTAL USERS = <NO OF RECORDS> in the table is printed. 
@Romakita Romakita added the good first issue Good for newcomers label Jun 12, 2020
@Romakita
Copy link

Originally this repository is just here to showing React with Ts.ED. Not to show TypeORM ^^ (there is a specific repo for that).
With your PR, we introduce TypeORM but the database isn't used by the backend code.
So your goal is to implement something to use it?

See you ;)

@panbhatt
Copy link
Contributor Author

It's being used. If we load the react front page a console message is displayed in the server logs, telling the no of employees present in the database. The code is present in 62-65 line in CalendarServive ts

@panbhatt
Copy link
Contributor Author

So sorry that I had integrate it here. If you don't want it here we can create another icon on tsed.io mentioning react n typeorm integration.

@Romakita
Copy link

Romakita commented Jun 13, 2020 •
edited
Loading

No worries @panbhatt ^^
Isn't a problem ;)

@panbhatt
Copy link
Contributor Author

Thanks. Originally I thought it would be good to integrate typeorm with react as react boilerplate is too old and not working with typeorm tsed new release version. Anywhere I can help would be a pleasure.

@Romakita
Copy link

Yep you've right :) and it's good idea. I think the example should be really better if it use only the database instead of mocked data with MemoryService. I totally missed the line where the employee number is checked ^^.
So if you have a time to improve the example you can replace all methods that use MemoryService and use TypeORM :)
It'll be a real pleasure to review it and help you on it ;)

On the TypeORM example I added an integration test example. I hope this example will help you^^

@panbhatt
Copy link
Contributor Author

Sure. I can do one react typeorm with sqlite demo replacing memory service with entity repository. And take typeorm integration test case example from other repo. Question will it be a new repo or pull request to another repo.

@Romakita
Copy link

Keep on this repo ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panbhatt @Romakita