Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torrent.pieces is not user-friendly #484

Open
dechamps opened this issue Sep 1, 2024 · 2 comments · May be fixed by #485
Open

Torrent.pieces is not user-friendly #484

dechamps opened this issue Sep 1, 2024 · 2 comments · May be fixed by #485

Comments

@dechamps
Copy link
Contributor

dechamps commented Sep 1, 2024

Currently, the Torrent.pieces field is the same as the pieces field in the Transmission RPC response, that is:

A bitfield holding pieceCount flags which are set to 'true' if we have the piece matching that position. JSON doesn't allow raw binary data, so this is a base64-encoded string.

While this makes sense for JSON, Python can do better. transmission-rpc could at least base64-decode the field to binary, or even better, could expose it as a list of bools.
@trim21
Copy link
Owner

trim21 commented Sep 2, 2024

we can make it bitmap in next major version

@trim21
Copy link
Owner

trim21 commented Sep 5, 2024

if I can finish this before tr 4.1.0 is released

@trim21 trim21 linked a pull request Sep 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(torrent)!: return BitMap as .pieces instead of base64 str trim21/transmission-rpc
2 participants
@dechamps @trim21