From b2415ea3dee76960ae48a170b734546bcebe3f17 Mon Sep 17 00:00:00 2001 From: Heshan Andrews Date: Thu, 25 Jul 2024 15:06:46 +0100 Subject: [PATCH] [APPENG-849] Fix prometheus client cant cast metric type gauge to info issue --- CHANGELOG.md | 4 ++++ gradle.properties | 2 +- .../transferwise/kafka/tkms/metrics/TkmsMetricsTemplate.java | 4 +++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e04f0cc..c466b13 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [0.29.1] 2024-07-25 +### Fixed +- Fixed the prometheus metrics cant cast metric type gauge to info issue. + ## [0.29.0] - 2024-07-16 ### Added diff --git a/gradle.properties b/gradle.properties index 187e7df..0de6718 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1 +1 @@ -version=0.29.0 +version=0.29.1 diff --git a/tw-tkms-starter/src/main/java/com/transferwise/kafka/tkms/metrics/TkmsMetricsTemplate.java b/tw-tkms-starter/src/main/java/com/transferwise/kafka/tkms/metrics/TkmsMetricsTemplate.java index 5b889c9..11c1687 100644 --- a/tw-tkms-starter/src/main/java/com/transferwise/kafka/tkms/metrics/TkmsMetricsTemplate.java +++ b/tw-tkms-starter/src/main/java/com/transferwise/kafka/tkms/metrics/TkmsMetricsTemplate.java @@ -34,7 +34,9 @@ @Slf4j public class TkmsMetricsTemplate implements ITkmsMetricsTemplate, InitializingBean { - public static final String GAUGE_LIBRARY_INFO = "tw_library_info"; + // Miccrometer 1.13 (which comes with Spring boot 3.3) doesn't properly convert gauge metrics with info suffix when using underscore, + // using dot here as a workaround + public static final String GAUGE_LIBRARY_INFO = "tw.library.info"; public static final String TIMER_PROXY_POLL = "tw_tkms_proxy_poll"; public static final String GAUGE_PROXY_POLL_IN_PROGRESS = "tw_tkms_proxy_poll_in_progress"; public static final String TIMER_PROXY_CYCLE = "tw_tkms_proxy_cycle";