Do not try to merge extract_failure signal when representer is used #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaglio
commented
Mar 19, 2019
| @@ -22,7 +22,7 @@ def self.Validate(skip_extract: false, name: "default", representer: false, key: | |||
| options = {task: activity, id: "contract.#{name}.validate", outputs: activity.outputs} | |||
|
|
|||
| # Deviate End.extract_failure to the standard failure track as a default. This can be changed from the user side. | |||
| options = options.merge(Activity::DSL.Output(:extract_failure) => Activity::DSL.Track(:failure)) unless skip_extract | |||
| options = options.merge(Activity::DSL.Output(:extract_failure) => Activity::DSL.Track(:failure)) unless skip_extract || representer | |||
There was a problem hiding this comment.
we add the extract step only unless skip_extract || representer so makes sense to have the same block here
|
PR already there for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #9
We don't have many tests (any tests with representer) - should we merge this for now and add an issue to add those tests?