Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: contribute this to otel #213

Closed
1 task done
gyliu513 opened this issue Nov 27, 2023 · 5 comments
Closed
1 task done

🚀 Feature: contribute this to otel #213

gyliu513 opened this issue Nov 27, 2023 · 5 comments

Comments

@gyliu513
Copy link
Contributor

Which component is this feature for?

All Packages

🔖 Feature description

I can see https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation already have some python instrumentation code, any plan to upstream this to otel? Thanks

🎤 Why is this feature needed ?

otel is the official repo for all instrumentations

✌️ How do you aim to achieve this?

move all repos to https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

Yes I am willing to submit a PR!

@nirga
Copy link
Member

nirga commented Nov 27, 2023

Hey @gyliu513 thanks for this!
We're still contemplating whether this needs to be officially part of OpenTelemetry or an official extension. We're also in the process of joining CNCF.
The main reasons are that to get proper observability for gen-AI applications, we needed to extend on the semantic conventions as defined in the official otel package, and adding the needed extensions is still in discussion. We're also doing something that is a bit "unorthodox" in the otel community which is sending prompts as span attributes - and this is also under discussion.

Having said that, since this is still 100% compatible with OpenTelemetry, I don't think that the fact that this is outside of the otel-contrib package should make a difference (and we're not even the first ones doing that).

@nirga nirga changed the title 🚀 Feature: Any plan contribute this to otel 🚀 Feature: contribute this to otel Nov 27, 2023
@gyliu513
Copy link
Contributor Author

Thanks @nirga for the clear explanation, it really helps! Yes, I have no comments if you want to keep this outside of otel-contrib, do you think we need to keep this open until we have a conclusion for above discussions?

@nirga
Copy link
Member

nirga commented Nov 27, 2023

Yeah, I'll keep it this open for reference for future inquiries

@nirga
Copy link
Member

nirga commented Dec 7, 2023

I've opened up discussions to this repo so closing this as I think there is a better place to discuss this.

@nirga nirga closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
@nirga
Copy link
Member

nirga commented Dec 7, 2023

(See #236)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants