php 8.1 compatibility

[adixon]

Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in phar:///usr/local/bin/civix/src/CRM/CivixBundle/Command/InitCommand.php on line 231

Says it all? Using php8.1, just downloaded civix via the tarball.

[totten]

@adixon That's weird. This is the context of line 231 (and it's the only trim() in the file):

    if (\CRM\CivixBundle\Utils\Commands::findExecutable('git')) {
      $result = trim(`git config --get $key`);
    }

Any idea how git config could return null? In the worst case, I would expect it to output '' or some textual noise. I'm not aware any null construct for pipes/subprocesses.

[adixon]

From what I remember of what I was doing then, I'd guess that git user.email or user.name had not been configured.

So it would appear that git config returns null if the key doesn't exist.