Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moment matching for brmsfit #4

Open
n-kall opened this issue Aug 10, 2023 · 4 comments
Open

Moment matching for brmsfit #4

n-kall opened this issue Aug 10, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@n-kall
Copy link
Collaborator

n-kall commented Aug 10, 2023

I think it would be good to have a moment_match.brmsfit method. It should probably return a modified brmsfit object with the draws replaced with the moment matched draws, so that further functions from brms would work (e.g. posterior_predict, see n-kall/priorsense#18). I'm not sure where the weights would be stored though. At some stage I think brms will store the posterior in draws format (rather than the current stanfit object), so that would help, but that will likely only happen in the next major release.

@n-kall n-kall self-assigned this Aug 10, 2023
@n-kall n-kall added the enhancement New feature or request label Aug 10, 2023
@topipa
Copy link
Owner

topipa commented Aug 31, 2023

Yes this would be a good addition! Have you done anything related to this yet? If not, I could also work on this. Do you think it makes sense as a first step to return the weights as part of a separate "iwmm" object (even though there is no such thing yet concretely) in addition to the brmsfit object?

@n-kall
Copy link
Collaborator Author

n-kall commented Sep 6, 2023

An iwmm object sounds quite useful! I haven't started anything related to this, so feel free if you have time

@n-kall
Copy link
Collaborator Author

n-kall commented Jan 16, 2024

It looks like you've made a lot of progress with the brmsfit method and the iwmm object.
I'm trying to improve the workflow in priorsense for brmsfit objects so I'm happy to help out with this. Would it make sense for me to work from the brmsfit-method branch?

@topipa
Copy link
Owner

topipa commented Jan 18, 2024

It looks like you've made a lot of progress with the brmsfit method and the iwmm object. I'm trying to improve the workflow in priorsense for brmsfit objects so I'm happy to help out with this. Would it make sense for me to work from the brmsfit-method branch?

Yes the basic structure is there, but it's still missing the part to update the brmsfit object. If you want, feel free to continue from that!

The iwmm object is still sort of a prototype, and is expected to change. If you have any ideas how to structure it, for example to benefit priorsense, please let me know 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants