Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide call letters for filename template #13

Open
mkomko opened this issue Apr 1, 2019 · 2 comments
Open

Provide call letters for filename template #13

mkomko opened this issue Apr 1, 2019 · 2 comments

Comments

@mkomko
Copy link
Contributor

mkomko commented Apr 1, 2019

I would like to request that the call letters (basically the name of the broadcasting tv station) are available for using them in a filename template (look for "callLetters" in the media item in the JSON data).

They are available in the JSON for the MLB media listing, but if I read the code correctly (which I am not at all sure of), the filename is generated before the media is selected.

I might take a look at it myself in the future, but if a lot of code has to be changed it might be tough for me.

Thanks in advance for your consideration!

@tonycpsu
Copy link
Owner

tonycpsu commented Apr 7, 2019

Well, it's not a small amount of code. You're correct that the filename is generated from the listing (the game / video being viewed), not the media source (the actual stream). That's probably incorrect, since with the way it's done now, there's not only no way to include the call letters, but also no way to include things like stream resolution, whether it's audio/video, etc.

At the same time, this isn't the highest priority thing right now considering it's more of an aesthetic thing for filenames, so I might not get to this one for a while. It'd be a different story if it were a one-line fix.

@mkomko
Copy link
Contributor Author

mkomko commented Apr 7, 2019

At the same time, this isn't the highest priority thing right now considering it's more of an aesthetic thing for filenames, so I might not get to this one for a while.

I totally agree, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants