Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative paths for WebSocket and mopidy.js #13

Closed
tkem opened this issue Feb 1, 2015 · 4 comments
Closed

Use relative paths for WebSocket and mopidy.js #13

tkem opened this issue Feb 1, 2015 · 4 comments
Labels

Comments

@tkem
Copy link
Owner

tkem commented Feb 1, 2015

See mopidy/mopidy.js#3

Both the path to mopidy.js and the ws path should default to ../mopidy/ instead of the absolute /mopidy/ for use with reverse proxies. Maybe also make these configurable for more advanced settings.

@tkem
Copy link
Owner Author

tkem commented Feb 1, 2015

Implementation hint: These could be passed to the app using data-* attributes in the tornado.html template. This would also make the check for isWebExtension() somewhat cleaner.

@tkem
Copy link
Owner Author

tkem commented Feb 1, 2015

TBD: How to resolve relative image URIs, such as those generated by mopidy-local-images. Probably this should be left to the proxy server...

@tkem
Copy link
Owner Author

tkem commented Feb 1, 2015

In the app's "Add Connection" page, it must also be possible to override the ws path.

@tkem tkem added the bug label Feb 1, 2015
@tkem
Copy link
Owner Author

tkem commented Feb 1, 2015

It might also be convenient to include our own version of mopidy.js with the Web extension:

  • no hassle with reverse proxies
  • known feature set, for example Mopidy.when in v0.5.0
  • better client caching when used with Tornado's static path versioning (to be verified), or even bundling all JS resources in a single minified file

@tkem tkem closed this as completed in 2b23892 Feb 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant