Separate out caml_startup-dependent code into runtime library
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrmr1993 at a first glance it looks good, but will re-check tomorrow. One thing, you have to bump the version of the root Cargo.toml file too. About the commented function in the doctest, is it not possible to make that one work? |
Done, good catch!
It's the first time I've come across tests in this format, so I'm afraid I'm not sure. I strongly suspect not -- there doesn't seem to be any way to specify additional external deps for those tests -- but that doesn't mean there isn't one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the utility functions for starting an OCaml runtime into their own library.
This is a trivial but breaking change. I've taken the liberty of bumping the version number accordingly.
This fixes #34.
Tested by:
dune utopin an OCaml project using this library to generate a rust native library (via a tweaked ocaml-rs)make test-all