Skip to content
This repository has been archived by the owner on Mar 30, 2022. It is now read-only.

Should button outlines be drawn in the disabledStrokeColor in the disabled state? (patch included) #57

Open
garethsb-ghost opened this issue Apr 5, 2011 · 0 comments

Comments

@garethsb-ghost
Copy link

Should button outlines be drawn in the disabledStrokeColor in the disabled state? In particular, the disabled state of an unchecked HUD checkbox is hard to distinguish from an enabled one.

I've patched BGHUDButtonCell.m locally as follows:

diff /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d/Framework/BGHUDButtonCell.m /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d-patched/Framework/BGHUDButtonCell.m >diff.txt
403c403
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
510c510
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
591c591
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
891c891
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
916c916
<                [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>                [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
961c961
<                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
983c983
<                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];

Best regards,
Gareth

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant