Skip to content
This repository has been archived by the owner on Mar 30, 2022. It is now read-only.

Vertical slider doesn't draw correctly in disabled state (patch included) #56

Open
garethsb-ghost opened this issue Apr 5, 2011 · 1 comment

Comments

@garethsb-ghost
Copy link

BGHUDAppKit looks great. Thank you, Tim!

BGHUDSliderCell doesn't draw a vertical slider correctly in the disabled state. I think this is just an oversight and easily fixed by applying the code from the horizontal variant:

diff /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d/Framework/BGHUDSliderCell.m /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d-patched/Framework/BGHUDSliderCell.m 
308,312c308,322
<    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] sliderTrackColor] set];
<    [path fill];
<    
<    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];
<    [path stroke];

---
>    if([self isEnabled]) {
>        
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] sliderTrackColor] set];
>        [path fill];
>        
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];
>        [path stroke];
>    } else {
>        
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledSliderTrackColor] set];
>        [path fill];
>        
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
>        [path stroke];
>    }

Thanks,
Gareth Sylvester-Bradley

@timthedevguy
Copy link
Owner

hmmm...I don't remember ever getting a notice of this one, I'll definitely get this and your other fixes in the repo, thanks for the help and sorry for the late reply.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants