Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit contract migration logic #17

Open
bekauz opened this issue Sep 25, 2024 · 0 comments
Open

revisit contract migration logic #17

bekauz opened this issue Sep 25, 2024 · 0 comments
Assignees

Comments

@bekauz
Copy link
Collaborator

bekauz commented Sep 25, 2024

          Probably just a template, I also do it, but keep in mind that if you have those endpoints, and someone will try to migrate or you will try to do a reply, this will be successful, meaning you will be able to migrate successfully, and using the reply will be successful if you don't handle it.

Removing the endpoints will force a fail here and won't allow to to migrate or use reply by mistake, so ideally you would remove it (or comment it) to make sure it doesn't do what you don't want it to.

Originally posted by @Art3miX in #15 (comment)

following up on feedback on a pr above

@bekauz bekauz self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant