Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work fully on Gnome 3.34 #19

Open
inducer opened this issue Sep 13, 2019 · 4 comments
Open

Doesn't work fully on Gnome 3.34 #19

inducer opened this issue Sep 13, 2019 · 4 comments

Comments

@inducer
Copy link

inducer commented Sep 13, 2019

As far as I can tell, the pop-up menu does not appear. Some keyboard shortcuts do appear to work, such as Super-plus and Super-minus. I'd be happy to help debug/fix, but I'm a bit lost where to start. How can I print something in the code and observe the result?

@timbertson
Copy link
Owner

Thanks for offering to help, I haven't upgraded to 3.34 yet.

To print something, there's a p(string) function in logging.ts, it should be imported in most modules already.

To see logs, I use journalctl --user -f | grep gnome-shell (or you can grep for slinger if you just want those logs)

@inducer
Copy link
Author

inducer commented Sep 15, 2019

Thanks! Here's what I've found: The issue seems to stem from calls to

Sys.Clutter.grab_pointer(backgroundActor)

which doesn't appear to be available anymore:

Sep 14 23:14:22 bolt gnome-shell[2731]: [slinger]:Error: TypeError: Sys.Clutter.grab_pointer is not a function

Following this MR in Gnome Shell, I tried to use the device manager approach introduced there. Unfortunately, it seems

this._keyboardDevice = dm.get_core_device(Clutter.InputDeviceType.KEYBOARD_DEVICE);

can and will return null at random points, often after suspend/resume, for reasons I don't understand, and the API docs (not linkable to individual functions of course, that'd be too nice) don't particularly help.

For now, I've resorted to simply commenting out the grab/ungrab pair, and things seem to work well.

@inducer
Copy link
Author

inducer commented Sep 16, 2019

OK, I lied. Commenting out the grab does not work, events don't reach the menu. I had simply forgotten to compile. I've complained about the occasional null values here:

https://gitlab.gnome.org/GNOME/mutter/issues/799

@inducer
Copy link
Author

inducer commented Sep 16, 2019

#20 has a draft PR with some TODOs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants