Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that glue(.envir =) is an environment #317

Closed
jennybc opened this issue Dec 21, 2023 · 0 comments
Closed

Enforce that glue(.envir =) is an environment #317

jennybc opened this issue Dec 21, 2023 · 0 comments

Comments

@jennybc
Copy link
Member

jennybc commented Dec 21, 2023

I introduced this in e2b74ff in response to #308.

But this did break some usage in the wild. I currently think those are cases of sub-optimal glue usage and have opened PRs or issues or, in the case of shinyCohortBuilder, sent an email. Here's what that looked like:

https://github.com/tidyverse/glue/blob/c98f106c420d658da8010627d4a2a4d19f97d758/revdep/problems.md

In the interest of doing a glue release, I'm rolling back the check that .envir is an environment, but I would like to bring it back in the future. For follow-up, here are the related issues or PRs, which lays the groundwork for a future release:

r-ash added a commit to reside-ic/traduire that referenced this issue Oct 1, 2024
This changed in tidyverse/glue#317 and is not
in current CRAN version of glue causing fairly confusing downstream
failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant