-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize names for steps that create dummy variables #918
Comments
Two that are especially confusingly named right now are
I feel like I'd lean toward keeping
|
Another verb we have going on here is |
I like |
overall a good idea. But I don't think the benefit of unifying these function names outweigh the annoyance we would get for changing them. |
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
The use of
dummy
in step names have lead to some confusion, especially with the addition ofstep_dummy_multi_choice()
andstep_dummy_extract()
which hasdummy
as a part of their name, while other steps such asstep_regex()
,step_count()
,step_indicate_na()
, andstep_holiday()
which do produce dummies, does not.Before I go any further I'm going to lay down some terminology.
Using the above definition I will say that
step_dummy()
produces a set of dummy variables.step_dummy_multi_choice()
produces a set of dummy variables.step_holiday()
produces a set of dummy variables.step_dummy_extract()
produces a set of count variables.step_indicate_na()
produces a single dummy variable.step_regex()
produces a single dummy variable.step_count()
produces a single count variable (whennormalize = FALSE
)A way to standardize the naming would be to turn
step_holiday() -> step_dummy_holiday()
,step_dummy_regex()
, etc, etc.not all dummy steps can have a related count step, but all count steps can have a related dummy step.
What I'm not sure what to do naming wise for steps that produces counts, as it is only
step_count()
andstep_dummy_extract()
.step_dummy_extract()
could in theory be changed to return dummies instead of counts, and create another step calledstep_count_extract()
that does whatstep_dummy_extract()
does now.All the above a using a somehow loose definition of
categorical effect
.The text was updated successfully, but these errors were encountered: