Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary quotes in re-registration error message #1201

Open
simonpcouch opened this issue Sep 10, 2024 · 0 comments · May be fixed by #1202
Open

remove unnecessary quotes in re-registration error message #1201

simonpcouch opened this issue Sep 10, 2024 · 0 comments · May be fixed by #1202
Labels
upkeep maintenance, infrastructure, and similar

Comments

@simonpcouch
Copy link
Contributor

Some "" that don't appear to need to be there.

parsnip/tests/testthat/_snaps/re_registration.md

Lines 3 to 10 in 4562458

Code
set_fit(model = "bart", eng = "dbarts", mode = "regression", value = list(
interface = "data.frame", data = c(x = "x.train", y = "y.train"), protect = c(
"x", "y"), func = c(pkg = "dbarts", fun = "bart"), defaults = list(verbose = TRUE,
keeptrees = TRUE, keepcall = FALSE)))
Condition
Error in `set_fit()`:
! The combination of engine `dbarts` and mode `regression` "" already has fit data for model `bart` and the new information being registered is different.

Noticed this in the transition to snapshot testing in #1190.
@simonpcouch simonpcouch added the upkeep maintenance, infrastructure, and similar label Sep 10, 2024
@simonpcouch simonpcouch linked a pull request Sep 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

correct formatting in model registration error tidymodels/parsnip
1 participant
@simonpcouch