Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old preview.threshold.network content on PR merge #9

Open
pdyraga opened this issue Feb 17, 2022 · 0 comments
Open

Remove old preview.threshold.network content on PR merge #9

pdyraga opened this issue Feb 17, 2022 · 0 comments
Assignees
@Battenfield @georgeweiler @michalsmiarowski @r-czajkowski

Comments

@pdyraga
Copy link
Member

pdyraga commented Feb 17, 2022 •
edited
Loading

Refs #7

As implemented in #8, content uploaded to preview.threshold.network from PRs targeting main remains in the bucket and is publicly available. This is not ideal for SEO reasons and dangling old code under the official domain can be used by scammers. I propose we delete the content from preview.threshold.network when a PR is closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Battenfield Battenfield

@georgeweiler georgeweiler

@michalsmiarowski michalsmiarowski

@r-czajkowski r-czajkowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pdyraga @Battenfield @georgeweiler @michalsmiarowski @r-czajkowski