Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm igraph::estimate_ functions that will soon be deprecated #174

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Jun 16, 2023

@szhorvat
Copy link

Just noticed something small which @thomasp85 might want to fix at the same time:

centrality_closeness() has cutoff=NULL as default while centrality_betweenness() has cutoff=-1. The meaning is identical, but for consistency, it would be nice to use NULL for both.

@thomasp85, I also wanted to let you know that igraph has an implementation of harmonic centrality with cutoffs. You might consider using this for centrality_closeness_harmonic().

@thomasp85 thomasp85 merged commit e7973bc into thomasp85:main Oct 30, 2023
@thomasp85
Copy link
Owner

Thanks, Maelle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants