Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Simple type vaildate for fromObject #186

Closed
way-zer opened this issue Jan 9, 2023 · 1 comment
Closed

Feature Request: Simple type vaildate for fromObject #186

way-zer opened this issue Jan 9, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@way-zer
Copy link

way-zer commented Jan 9, 2023

For array and Message, it is Ok, vaildate throught forEach and child fromObject.

But for base type, it may be wrong, like:

  • Array would be set to a string field.
  • String would be set to a enum field.
  • May be more.

I'm using with pb-text-format-to-json, there are two problem:

  • repeated field may get a object: convert to array with single item.
  • enum field get string: convert name to number.
@thesayyn thesayyn added enhancement New feature or request help wanted Extra attention is needed labels Mar 23, 2023
@thesayyn
Copy link
Owner

thesayyn commented Nov 16, 2023

This should be fixed with the rust rewrite. could you confirm that?

See #255

@thesayyn thesayyn closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants