Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture glitches: whitespace & borders #8

Open
gitblit opened this issue May 5, 2014 · 5 comments
Open

Capture glitches: whitespace & borders #8

gitblit opened this issue May 5, 2014 · 5 comments

Comments

@gitblit
Copy link

gitblit commented May 5, 2014

I've been playing around with this tool and I'd like to use it, but for my immediate need it's got an issue. It doesn't like whitespace with bordered boundaries. I've linked to a tarball with examples of what I mean. Perhaps   would be appropriate? I'm not sure.

Additionally, there is a capturing glitch when your default shell is not bash - or at least my zsh problem disappeared after changing my default shell and logging back in. An example of this is also in the tarball.

http://gitblit.com/capture-glitches.tar.gz

@theonewolf
Copy link
Owner

Thanks for the great report. I'm currently looking into it.

I'm glad we can actually use the tool to report bugs to each other, this is way more helpful than I thought possible!

I can reproduce the mc issues, and I think that will be enough to root cause the other example as well.

As for zsh that is odd, I use fish as my shell of choice and in lots of my recordings and never had an issue. I have zsh installed though as it used to be my shell of choice before I found fish.

Could you tell me the output of this: python -c "from sys import stdout; print stdout.encoding"

@gitblit
Copy link
Author

gitblit commented May 6, 2014

UTF-8. I'm on Ubuntu 14.04, if that makes a difference to you.

@theonewolf
Copy link
Owner

That's exactly the same as me.

@gitblit
Copy link
Author

gitblit commented May 11, 2014

Hmm. Thanks for the tip on fish. After using it for 5 mins on my laptop I can see it's appeal. I'm going to give that a go on my main desktop this week. As for this bug, it would be good to get that fixed, if you can... but since I needed to get something shared I ended up using asciinema.

@theonewolf
Copy link
Owner

This commit 3f759f4, not an official release yet, partially fixes the mc issues.

Could you test it out and let me know anything odd you notice? I'm noticing a few misaligned bars, but borders and everything else appears to mostly work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants