From 2490053dd5ca651c81a720c16e9332d7779da3f1 Mon Sep 17 00:00:00 2001
From: Ilya Artamonov <hire@ilya-artamonov.ru>
Date: Sat, 15 Jul 2023 22:06:26 +0300
Subject: [PATCH] refactor: Some improvements for File input component

---
 .../fileInput/examples/FileInpDefault.vue     |  3 +-
 .../fileInput/examples/FileInpDropZone.vue    |  6 +-
 .../fileInput/examples/FileInpHelper.vue      |  4 +-
 .../fileInput/examples/FileInpSize.vue        | 11 +--
 .../fileInput/examples/MultipleFile.vue       | 30 +++----
 src/components/FileInput/FileInput.vue        | 85 ++++++++++++-------
 .../composables/useFileInputClasses.ts        | 26 +++---
 7 files changed, 91 insertions(+), 74 deletions(-)

diff --git a/docs/components/fileInput/examples/FileInpDefault.vue b/docs/components/fileInput/examples/FileInpDefault.vue
index 75c04713..38d661e0 100644
--- a/docs/components/fileInput/examples/FileInpDefault.vue
+++ b/docs/components/fileInput/examples/FileInpDefault.vue
@@ -8,6 +8,5 @@
 import FileInput from '../../../../src/components/FileInput/FileInput.vue'
 import { ref } from 'vue'
 
-const file = ref()
-
+const file = ref(null)
 </script>
diff --git a/docs/components/fileInput/examples/FileInpDropZone.vue b/docs/components/fileInput/examples/FileInpDropZone.vue
index ca08d6de..4b1c8d67 100644
--- a/docs/components/fileInput/examples/FileInpDropZone.vue
+++ b/docs/components/fileInput/examples/FileInpDropZone.vue
@@ -1,8 +1,6 @@
 <template>
   <FileInput v-model="file" :dropzone="true">
-    <p class="!mt-1 text-xs text-gray-500 dark:text-gray-400">
-      SVG, PNG, JPG or GIF (MAX. 800x400px)
-    </p>
+    <p class="!mt-1 text-xs text-gray-500 dark:text-gray-400">SVG, PNG, JPG or GIF (MAX. 800x400px)</p>
   </FileInput>
 </template>
 
@@ -10,5 +8,5 @@
 import FileInput from '../../../../src/components/FileInput/FileInput.vue'
 import { ref } from 'vue'
 
-const file = ref('')
+const file = ref(null)
 </script>
diff --git a/docs/components/fileInput/examples/FileInpHelper.vue b/docs/components/fileInput/examples/FileInpHelper.vue
index 8a013f88..05ce29f2 100644
--- a/docs/components/fileInput/examples/FileInpHelper.vue
+++ b/docs/components/fileInput/examples/FileInpHelper.vue
@@ -1,7 +1,7 @@
 <template>
   <div>
     <FileInput v-model="file" label="Upload file">
-      <p class='!mt-1 text-sm text-gray-500 dark:text-gray-300'>SVG, PNG, JPG or GIF (MAX. 800x400px).</p>
+      <p class="!mt-1 text-sm text-gray-500 dark:text-gray-300">SVG, PNG, JPG or GIF (MAX. 800x400px).</p>
     </FileInput>
   </div>
 </template>
@@ -10,5 +10,5 @@
 import FileInput from '../../../../src/components/FileInput/FileInput.vue'
 import { ref } from 'vue'
 
-const file = ref('')
+const file = ref(null)
 </script>
diff --git a/docs/components/fileInput/examples/FileInpSize.vue b/docs/components/fileInput/examples/FileInpSize.vue
index beaf07c9..b0fe5c1a 100644
--- a/docs/components/fileInput/examples/FileInpSize.vue
+++ b/docs/components/fileInput/examples/FileInpSize.vue
@@ -1,12 +1,13 @@
 <template>
-  <div class='flex flex-col gap-5'>
-    <FileInput size="xs" label="Small size" />
-    <FileInput size="sm" label="Default size" />
-    <FileInput size="lg" label="Large size" />
+  <div class="flex flex-col gap-5">
+    <FileInput size="xs" v-model="file" label="Small size" />
+    <FileInput size="sm" v-model="file" label="Default size" />
+    <FileInput size="lg" v-model="file" label="Large size" />
   </div>
 </template>
 
 <script setup>
 import FileInput from '../../../../src/components/FileInput/FileInput.vue'
-
+import { ref } from 'vue'
+const file = ref(null)
 </script>
diff --git a/docs/components/fileInput/examples/MultipleFile.vue b/docs/components/fileInput/examples/MultipleFile.vue
index 69dd4c4c..d50ac3a9 100644
--- a/docs/components/fileInput/examples/MultipleFile.vue
+++ b/docs/components/fileInput/examples/MultipleFile.vue
@@ -1,19 +1,17 @@
 <template>
-    <div>
-      <FileInput multiple v-model="files" label="Upload file" />
-      <div class="mt-4 -mb-7 border-[1px] border-gray-300 dark:border-gray-600 p-2 rounded-md" v-if="files.length !== 0">
-        <div v-for="file in files" :id="file">
-            {{ file.name }}
-        </div>
+  <div>
+    <FileInput multiple v-model="files" label="Upload file" />
+    <div class="mt-4 -mb-7 border-[1px] border-gray-300 dark:border-gray-600 p-2 rounded-md" v-if="files.length !== 0">
+      <div v-for="file in files" :key="file">
+        {{ file.name }}
       </div>
     </div>
-  </template>
-  
-  <script setup>
-  import FileInput from '../../../../src/components/FileInput/FileInput.vue'
-  import { ref } from 'vue'
-  
-  const files = ref([])
-  
-  </script>
-  
\ No newline at end of file
+  </div>
+</template>
+
+<script setup>
+import FileInput from '../../../../src/components/FileInput/FileInput.vue'
+import { ref } from 'vue'
+
+const files = ref([])
+</script>
diff --git a/src/components/FileInput/FileInput.vue b/src/components/FileInput/FileInput.vue
index 7266037e..99456536 100644
--- a/src/components/FileInput/FileInput.vue
+++ b/src/components/FileInput/FileInput.vue
@@ -3,26 +3,30 @@
     <div v-if="!dropzone">
       <label>
         <span :class="labelClasses">{{ label }}</span>
-        <input :class="fileInpClasses" :multiple="multiple" @change="handleChange" type="file">
+        <input :class="fileInpClasses" :multiple="multiple" @change="handleChange" type="file" />
       </label>
       <slot />
     </div>
-    <div v-else @change="handleChange" @drop="dropFileHandler" @dragover="dragOverHandler"
-      class="flex items-center justify-center">
+    <div v-else @change="handleChange" @drop="dropFileHandler" @dragover="dragOverHandler" class="flex items-center justify-center">
       <label :class="dropzoneLabelClasses">
         <div :class="dropzoneWrapClasses">
-          <svg class="w-8 h-8 text-gray-500 dark:text-gray-400" aria-hidden="true" xmlns="http://www.w3.org/2000/svg"
-            fill="none" viewBox="0 0 20 16">
-            <path stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="2"
-              d="M13 13h3a3 3 0 0 0 0-6h-.025A5.56 5.56 0 0 0 16 6.5 5.5 5.5 0 0 0 5.207 5.021C5.137 5.017 5.071 5 5 5a4 4 0 0 0 0 8h2.167M10 15V6m0 0L8 8m2-2 2 2" />
+          <svg class="w-8 h-8 text-gray-500 dark:text-gray-400" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 20 16">
+            <path
+              stroke="currentColor"
+              stroke-linecap="round"
+              stroke-linejoin="round"
+              stroke-width="2"
+              d="M13 13h3a3 3 0 0 0 0-6h-.025A5.56 5.56 0 0 0 16 6.5 5.5 5.5 0 0 0 5.207 5.021C5.137 5.017 5.071 5 5 5a4 4 0 0 0 0 8h2.167M10 15V6m0 0L8 8m2-2 2 2"
+            />
           </svg>
           <div v-if="!model">
-            <p :class="dropzoneTextClasses"><span class="font-semibold">Click to upload</span> or
-              drag and drop
+            <p :class="dropzoneTextClasses">
+              <span class="font-semibold"> Click to upload </span>
+              or drag and drop
             </p>
             <slot />
           </div>
-          <p v-else>File: {{ model.name }}</p>
+          <p v-else>File: {{ dropZoneText }}</p>
         </div>
         <input type="file" class="hidden" />
       </label>
@@ -33,21 +37,35 @@
 <script setup lang="ts">
 import { computed } from 'vue'
 import { useFileInputClasses } from '@/components/FileInput/composables/useFileInputClasses'
+import { isArray } from 'lodash-es'
 
 interface FileInputProps {
-  modelValue?: any;
-  label?: string;
-  size?: string;
-  dropzone?: boolean;
-  multiple?: boolean;
+  modelValue?: File | File[] | null
+  label?: string
+  size?: string
+  dropzone?: boolean
+  multiple?: boolean
 }
 const props = withDefaults(defineProps<FileInputProps>(), {
-  value: null,
+  modelValue: null,
   label: '',
   size: 'sm',
   dropzone: false,
   multiple: false,
 })
+const dropZoneText = computed(() => {
+  if (isArray(props.modelValue)) {
+    return props.modelValue.map((el) => el.name).join(', ')
+  } else if (props.modelValue instanceof FileList) {
+    return Array.from(props.modelValue)
+      .map((el) => el.name)
+      .join(',')
+  } else if (props.modelValue instanceof File) {
+    return props.modelValue.name || ''
+  } else {
+    return ''
+  }
+})
 
 const emit = defineEmits(['update:modelValue'])
 const model = computed({
@@ -61,22 +79,29 @@ const model = computed({
 
 const handleChange = (event: Event) => {
   const target = event.target as HTMLInputElement
-  if(props.multiple) { model.value = target.files }
-  else { model.value = target.files?.[0] }
+  if (props.multiple) {
+    model.value = Array.from(target.files ?? [])
+  } else {
+    model.value = target.files?.[0] ?? null
+  }
 }
 
-const dropFileHandler = (event: any) => {
+const dropFileHandler = (event: DragEvent) => {
   event.preventDefault()
-
-  if (event.dataTransfer.items) {
-    [...event.dataTransfer.items].forEach((item, i) => {
+  const arr: File[] = []
+  if (event.dataTransfer?.items) {
+    Object.values(event.dataTransfer.items).forEach((item: DataTransferItem) => {
       if (item.kind === 'file') {
-        const file = item.getAsFile()
-        model.value = file
+        arr.push(item.getAsFile() as File)
       }
     })
-  } else {
-    [...event.dataTransfer.files].forEach((file, i) => {
+    if (props.multiple) {
+      model.value = arr
+    } else {
+      model.value = arr[0]
+    }
+  } else if (event.dataTransfer?.files) {
+    Object.values(event.dataTransfer.files).forEach((file: File) => {
       model.value = file
     })
   }
@@ -86,11 +111,5 @@ const dragOverHandler = (event: Event) => {
   event.preventDefault()
 }
 
-const {
-  fileInpClasses,
-  labelClasses,
-  dropzoneLabelClasses,
-  dropzoneWrapClasses,
-  dropzoneTextClasses,
-} = useFileInputClasses(props.size)
+const { fileInpClasses, labelClasses, dropzoneLabelClasses, dropzoneWrapClasses, dropzoneTextClasses } = useFileInputClasses(props.size)
 </script>
diff --git a/src/components/FileInput/composables/useFileInputClasses.ts b/src/components/FileInput/composables/useFileInputClasses.ts
index 387cdd76..1c1bf596 100644
--- a/src/components/FileInput/composables/useFileInputClasses.ts
+++ b/src/components/FileInput/composables/useFileInputClasses.ts
@@ -1,20 +1,22 @@
 import { simplifyTailwindClasses } from '@/utils/simplifyTailwindClasses'
 import { computed } from 'vue'
 
-const fileInpDefaultClasses = 'block w-full text-sm text-gray-900 border-[1px] border-gray-300 rounded-lg cursor-pointer bg-gray-50 dark:text-gray-400 focus:outline-none dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400'
+const fileInpDefaultClasses =
+  'block w-full text-sm text-gray-900 border-[1px] border-gray-300 rounded-lg cursor-pointer bg-gray-50 dark:text-gray-400 focus:outline-none dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400'
 const fileInpLabelClasses = 'block mb-2 text-sm font-medium text-gray-900 dark:text-white'
-const fileInpDropzoneClasses = 'flex flex-col items-center justify-center w-full h-64 border-2 border-gray-300 border-dashed rounded-lg cursor-pointer bg-gray-50 dark:hover:bg-bray-800 dark:bg-gray-700 hover:bg-gray-100 dark:border-gray-600 dark:hover:border-gray-500 dark:hover:bg-gray-600'
+const fileInpDropzoneClasses =
+  'flex flex-col items-center justify-center w-full h-64 border-2 border-gray-300 border-dashed rounded-lg cursor-pointer bg-gray-50 dark:hover:bg-bray-800 dark:bg-gray-700 hover:bg-gray-100 dark:border-gray-600 dark:hover:border-gray-500 dark:hover:bg-gray-600'
 const fileDropzoneWrapClasses = 'flex flex-col items-center justify-center pt-5 pb-6'
 const fileDropzoneDefaultTextClasses = '!-mb-2 text-sm text-gray-500 dark:text-gray-400'
 
 export function useFileInputClasses(size: string) {
-	const fileInpClasses = computed(() => {
-		return simplifyTailwindClasses(fileInpDefaultClasses, 'text-' + size)
-	})
+  const fileInpClasses = computed(() => {
+    return simplifyTailwindClasses(fileInpDefaultClasses, 'text-' + size)
+  })
 
-	const labelClasses = computed(() => {
-		return fileInpLabelClasses
-	})
+  const labelClasses = computed(() => {
+    return fileInpLabelClasses
+  })
 
   const dropzoneLabelClasses = computed(() => {
     return fileInpDropzoneClasses
@@ -28,11 +30,11 @@ export function useFileInputClasses(size: string) {
     return fileDropzoneDefaultTextClasses
   })
 
-	return {
-		fileInpClasses,
-		labelClasses,
+  return {
+    fileInpClasses,
+    labelClasses,
     dropzoneLabelClasses,
     dropzoneWrapClasses,
     dropzoneTextClasses,
-	}
+  }
 }