Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include flag in SelexDataset to use sparse counts instead of non-sparse counts (default) #97

Open
1 of 4 tasks
ilibarra opened this issue Dec 13, 2022 · 1 comment
Open
1 of 4 tasks
Assignees

Comments

@ilibarra
Copy link
Member

ilibarra commented Dec 13, 2022

  • New flag sparse=True.
  • Two tests:
    • Conversion of int to sparse does not generate dataframes with different shape
    • The values between a non-sparse and a sparse object are the same e.g. sum.
@ilibarra ilibarra self-assigned this Dec 15, 2022
@ilibarra
Copy link
Member Author

ilibarra commented Dec 15, 2022

The flag/conversion is now implemented and in development. However, PyTorch data loader doesn't handle sparse matrices with ease, so we cannot consider this case for extensive testing at this point, unfortunately. We would need something like a sparse to torch conversion during the dataloader step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant