Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renaming/refactoring of optimize_iterative/optimize function into model.MultiBind #105

Open
2 tasks
ilibarra opened this issue Jan 3, 2023 · 0 comments
Open
2 tasks

renaming/refactoring of optimize_iterative/optimize function into model.MultiBind #105

ilibarra opened this issue Jan 3, 2023 · 0 comments
Labels
prio:medium

Comments

@ilibarra
Copy link
Member

ilibarra commented Jan 3, 2023

We need to test other models, so, the optimize routine can have slight variants based on use case.

  • relocate mb.tl.optimize and mb.tl.optimize_iterative as an abstract method of a intermediate child class name TrainableModel, downstream of the parent class of MultiBind.
  • all classes that inherit from TrainableModel need a optimize implementation. optimize_iterative is optional for MultiBind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio:medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ilibarra