Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Dockerfiles from ot-ui-apps #26

Open
1 of 3 tasks
AnikaBongaarts opened this issue Apr 5, 2024 · 1 comment
Open
1 of 3 tasks

Remove unused Dockerfiles from ot-ui-apps #26

AnikaBongaarts opened this issue Apr 5, 2024 · 1 comment
Assignees

Comments

@AnikaBongaarts
Copy link

AnikaBongaarts commented Apr 5, 2024

There are two supposedly obsolete Dockerfiles in ot-ui-apps:

thehyve/ot-ui-apps:apps/genetics/Dockerfile
thehyve/ot-ui-apps:apps/platform/Dockerfile
We should remove them (open PR to EBI repo) and, in the meantime, exclude them from the Snyk dashboard so we don’t keep getting vulnerability warnings.

  • remove the above from Snyk dashboard
  • remove from our repo (in which we already add an up-to-date version alongside it)
  • optional: present a new PR to EBI repo, explicitly phrasing it as an update; Dockerise application opentargets/ot-ui-apps#30 was rejected at the time
@AnikaBongaarts
Copy link
Author

Old comments:
Removing them in the patch in which we add the actual up-to-date Dockerfile sounds great! That commit is basically an update to code that’s already there, as I tried to argue a while back, so it’s counterproductive to keep the old and new Dockerfiles in the repo side by side like we’re doing now. Regardless of whether we present the update and intention to keep contributing updates to EBI afterwards.

Actually on Snyk scanning of these images already appear as inactive (there is an “Activate” button next to them), but they are not hidden in the list so it’s easy to think they are still being tracked (like I did)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants