Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need AST transform tests #24

Open
taras opened this issue Sep 23, 2016 · 2 comments
Open

We need AST transform tests #24

taras opened this issue Sep 23, 2016 · 2 comments

Comments

@taras
Copy link
Member

taras commented Sep 23, 2016

I've been experimenting with inline let and it behaves unpredictably. There could be something wrong with the AST transform code. We need to add node tests for it.

@rwjblue
Copy link
Contributor

rwjblue commented Sep 23, 2016

They will just be super brittle. We need to focus on testing the things we care about, which in this case is whatever thing at runtime that you noticed was wrong.

@mmun
Copy link
Contributor

mmun commented Sep 30, 2016

Do you have an example? The AST transform is fairly straightforward and only touches stable parts of the AST so I would be surprised if it broken in any version. It seems more likely that helper runtime code is malfunctioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants