From 3347fa49d500964f0209122d8d36c920d1feafcc Mon Sep 17 00:00:00 2001 From: Ewoud Kohl van Wijngaarden Date: Wed, 31 Mar 2021 11:35:34 +0200 Subject: [PATCH] Fixes #32238 - Bind systemd socket to IPv6 By default foreman.socket binds to IPv4 only. This was done to make matching it in Puma easier, but it's not really what should be done in 2021 where everything should be dual stack by default. In aecc3187253ada61a311b5229d215452bd6d67b7 the need for this matching in Puma was removed which makes it much more flexible. The default should be updated. Note that the installer currently always overrides it so it's not really a difference for most, but I want to modify the installer to rely on the default. --- extras/systemd/foreman.socket | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/extras/systemd/foreman.socket b/extras/systemd/foreman.socket index a89a4f04fd0..dccbf5d16f9 100644 --- a/extras/systemd/foreman.socket +++ b/extras/systemd/foreman.socket @@ -2,11 +2,7 @@ Description=Foreman HTTP Server Accept Sockets [Socket] -# Note Puma must be configured to listen on the same IP/port. If there's a -# mismatch, it will bind again. The port can already be in use, for example when -# systemd is configured with [::]:3000 but Puma with 0.0.0.0:3000. The port is -# then already in use. -ListenStream=0.0.0.0:3000 +ListenStream=3000 # Socket options matching Puma defaults NoDelay=true