Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint singleton-comparison false positive vs. sqlalchemy filter for True/False comparision #7

Open
thadeshammer opened this issue Aug 11, 2024 · 0 comments
Assignees
Labels
3rd party dep bug Something isn't working

Comments

@thadeshammer
Copy link
Owner

Pylint will attempt to mislead us into changing SQLAlchemy/SQLModel filters to make the following change:

select(User).where(Used.deleted == True)  # which is correct for a SQLAlchemy filter

Pylint wants us to change it to

select(User).where(User.deleted is True)  # which will bomb in a SQLAlchemy filter like this

This is slated to be triaged and fixed here: pylint-dev/pylint#9472

I subscribed to that thread, so now, we wait.

@thadeshammer thadeshammer added the invalid This doesn't seem right label Aug 11, 2024
@thadeshammer thadeshammer self-assigned this Aug 11, 2024
@thadeshammer thadeshammer added bug Something isn't working 3rd party dep and removed invalid This doesn't seem right labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party dep bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant