Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to define flag names with numerical values #1966

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

john-science
Copy link
Member

@john-science john-science commented Oct 21, 2024

What is the change?

Historically, ARMI Flags have been all-caps and English Alphabet only: FUEL, DUCT``, FEED`, and so on. And if you added a numerical digit into the mix, it would be ignored (for various reasons).

This PR makes it so if the user defines a parameter it will be treated as an exception to the "letters only" rule, and handled exactly as-is.

This is only meant to support "upper case letters and numbers though". This PR still does not support flag names with:

  • whitespace
  • non-English characters
  • special characters, like punctuation
  • very long names

Why is the change being made?

This was a feature request made by downstream users.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the feature request Smaller user request label Oct 21, 2024
@john-science john-science changed the title Allow for users to define flags with numerical values Allow users to define flag names with numerical values Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant