@Profile annotation is not working on @WorkflowImpl with workers-auto-discovery

[hedonihilist]

Expected Behavior

When workers-auto-discovery is configured and @Profile annotation is used on top of @WorkflowImpl, if the profile condition doesn't match, the workflow should not be used.

Actual Behavior

Regardless of the condition in @Profile all classes annotated with @WorkflowImpl will be used.

Steps to Reproduce the Problem

1. Create a workflow and its implementation SomeWorkflowImpl
2. Annotate SomeWorkflowImpl with @WorkflowImpl and @Profile("!local")
3. Run the application with local spring profile. The SomeWorkflowImpl can still be discovered and workers will be created.

Specifications

• Version: temporal-spring-boot-autoconfigure-alpha-1.18.2.jar
• Platform: mac

Some investigations

ClassPathScanningCandidateComponentProvider is used to scan the package to find workflows.

  private Collection<Class<?>> autoDiscoverWorkflowImplementations() {
    ClassPathScanningCandidateComponentProvider scanner =
        new ClassPathScanningCandidateComponentProvider(false);
    scanner.addIncludeFilter(new AnnotationTypeFilter(WorkflowImpl.class));
    Set<Class<?>> implementations = new HashSet<>();
    for (String pckg : properties.getWorkersAutoDiscovery().getPackages()) {
      Set<BeanDefinition> candidateComponents = scanner.findCandidateComponents(pckg);
      for (BeanDefinition beanDefinition : candidateComponents) {
        try {
          implementations.add(Class.forName(beanDefinition.getBeanClassName()));
        } catch (ClassNotFoundException e) {
          throw new BeanDefinitionValidationException(
              "Fail loading class for bean definition " + beanDefinition, e);
        }
      }
    }
    return implementations;
  }

But it seems the Environment is not passed in. According to spring doc
The Environment is need to evaluate @Conditional annotations.

[Quinn-With-Two-Ns]

Profile effects what beans are included, technically workflow classes are not beans by intention, but I think it would be resonable here to respect Profile. Are you aware of any other spring boot projects that apply Profile to non beans?

[hedonihilist]

Are you aware of any other spring boot projects that apply Profile to non beans?

No I haven't know whether there're such projects. I am not saying we should do that but there seems to be missing some Spring-aware configurations to dynamically disable some task queue/workers. Maybe This can be achieved by some configuration beans before starting the workers?

What I am doing now is set the auto start worker to false, and manually register the conditional workers to worker factory. Maybe this kind of operations can be configured by some beans?

[hedonihilist]

Or could you give me some advice here on what's the recommend way to conditionally enable/disable workflows?

[Quinn-With-Two-Ns]

Your options currently are to use explicit configuration or put them in separate packages