New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Allow `--defaultdb` flag to be passed to schema job #433

Open

rikkuness opened this issue Oct 17, 2023 · 0 comments

Labels

enhancement good first issue

rikkuness commented Oct 17, 2023

Is your feature request related to a problem? Please describe.

When deploying via Helm there appears to be no way to set the --defaultdb flag, other flags have an optional env var but it looks like defaultdb does not https://github.com/temporalio/temporal/blob/main/tools/sql/main.go#L193-L196

Describe the solution you'd like

Either the flag should have an env var setting like other flags eg. SQL_DEFAULTDB or allow passing of arbitrary flags to the command in https://github.com/temporalio/helm-charts/blob/master/templates/server-job.yaml#L90

Additional context

The text was updated successfully, but these errors were encountered:

rikkuness added the enhancement label

robholland added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment