Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Document] Potentially misleading inline comment for PollWorkflowTaskQueueResponse #299

Open
taonic opened this issue Jun 16, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@taonic
Copy link
Contributor

taonic commented Jun 16, 2023

What are you really trying to do?

To clearly understand the scope of the workflow history returned in PollWorkflowTaskQueueResponse.

Describe the issue

At the moment, the inline comment is stated as below:

The history for this workflow, which will either be complete or partial. Partial histories
are sent to workers who have signaled that they are using a sticky queue when completing
a workflow task.

However, the term "complete" can be misleading as for long event history, this will only return the first page and rely on next_page_token for subsequent fetches.

@taonic taonic added the bug Something isn't working label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant