Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: algorithm output does not indicate when it has encountered transient error conditions #108

Open
shrouxm opened this issue Jun 12, 2024 · 0 comments
Labels
bug Something isn't working Engineering

Comments

@shrouxm
Copy link
Member

shrouxm commented Jun 12, 2024

Description

Currently when the algorithm encounters a transient error (e.g. SoilWeb API timeout) it logs an error and then tries a fallback API, which might return less accurate data. We should communicate what happened in the algorithm's output so that downstream clients can decide whether/how to retry.

Additional context

This can be triggered reliably by querying coordinates which don't have data (e.g. NOTCOM), like this coordinate pair:

{"lat": 34.92816, "lon": -114.80764}

But could happen for any coordinate due to transient network issues, which could result in suboptimal data being stored in a cache.

@shrouxm shrouxm added this to the LandPKS Backlog milestone Jun 12, 2024
@shrouxm shrouxm changed the title tech debt: clarify logging behaviour on failure cases tech debt/bug?: clarify logging behaviour on failure cases Jun 12, 2024
@shrouxm shrouxm added the bug Something isn't working label Jun 12, 2024
@shrouxm shrouxm changed the title tech debt/bug?: clarify logging behaviour on failure cases bug: algorithm output does not indicate when it has encountered transient error conditions Jun 13, 2024
@shrouxm shrouxm removed the tech-debt label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Engineering
Projects
Status: Todo
Development

No branches or pull requests

2 participants