Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_DEGREEOFESTABLISHMENT_NOTEMPTY #288

Closed
Tasilee opened this issue Feb 10, 2024 · 8 comments
Closed

TG2-VALIDATION_DEGREEOFESTABLISHMENT_NOTEMPTY #288

Tasilee opened this issue Feb 10, 2024 · 8 comments
Labels
Completeness OTHER Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 10, 2024

TestField Value
GUID 0fa16c7e-eb9c-4add-9193-aca6087d6636
Label VALIDATION_DEGREEOFESTABLISHMENT_NOTEMPTY
Description Is there a value in dwc:degreeOfEstablishment?
TestType Validation
Darwin Core Class Occurrence
Information Elements ActedUpon dwc:degreeOfEstablishment
Information Elements Consulted
Expected Response COMPLIANT if dwc:degreeOfEstablishment is bdq:NotEmpty; otherwise NOT_COMPLIANT
Data Quality Dimension Completeness
Term-Actions DEGREEOFESTABLISHMENT_NOTEMPTY
Parameter(s)
Source Authority
Specification Last Updated 2024-02-10
Examples [dwc:degreeOfEstablishment="native": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:degreeOfEstablishment is bdq:NotEmpty"]
[dwc:degreeOfEstablishment="": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:degreeOfEstablishment is bdq:Empty"]
Source TG2
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes The vast majority of current biodiversity data will be expected to not have a value in dwc:degreeofestablishment. This test could have value in determining 'quality' for a specific set of data quality needs/use cases.
@Tasilee Tasilee added TG2 Validation OTHER Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT Completeness CORE TG2 CORE tests labels Feb 10, 2024
@ymgan
Copy link
Collaborator

ymgan commented Feb 12, 2024

noted in #289

References: Darwin Core Maintenance Group (2021). Pathway Controlled Vocabulary List of Terms. Biodiversity Information Standards (TDWG). (https://dwc.tdwg.org/pw/)

not sure if we want to be consistent with https://dwc.tdwg.org/ or http://rs.tdwg.org/dwc/doc/ ?

@chicoreus
Copy link
Collaborator

Why does the note discuss leading or trailing whitespace? This is a test for EMPTY, therefore that text is not applicable.

This is one of several supplementary tests that, unlike core, almost certainly do not apply to flat Occurrence records. There are several tests like this that are very likely to apply to regional checklist data, probably attached to a Taxon record. That these tests are different in this sense needs at least to go into the notes, and probably elsewhere in a tag linked to higher level documentation about the assumptions of uses that the tests apply to.

In the absence of a clear use, this feels like it should be an issue rather than a validation.

@chicoreus
Copy link
Collaborator

This test is valuable, but applies poorly to the CORE use case as defined by TG3. Almost all occurrence data will (correctly) have no value in this term. It is very likely valuable for regional checklist data under invasive species use cases, but doesn't fit into CORE.

@chicoreus
Copy link
Collaborator

This test and #289 very likely need to consider other terms to assess whether a value should be present in the term. When a taxon is not introduced, dwc:pathway would be expected to be empty.

Non trivial work, and clear explication of the use case needed for both this and #289

@chicoreus
Copy link
Collaborator

Additional terms very likely needed as Consulted Information Elements.

@ArthurChapman
Copy link
Collaborator

Thanks @ymgan - minor but updated link.

@ArthurChapman
Copy link
Collaborator

@chicoreus - the use case is discussed in detail in the Groom et al. reference for this, Pathway, etc. There has been extensive discussion on these over the past few years and hence their addition to Darwin Core.

Removed reference to leading and trailing blanks.

@Tasilee
Copy link
Collaborator Author

Tasilee commented Feb 18, 2024

As per my comments on #285, this would have to be Supplementary on the basis of returning a high percentage of EMPTY values (for now)?

@Tasilee Tasilee added the Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. label Feb 18, 2024
@Tasilee Tasilee removed the NEEDS WORK label Apr 2, 2024
@Tasilee Tasilee closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completeness OTHER Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Projects
None yet
Development

No branches or pull requests

4 participants