Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-AMENDMENT_DEGREEOFESTABLISHMENT_STANDARDIZED #276

Open
ArthurChapman opened this issue Feb 8, 2024 · 18 comments
Open

TG2-AMENDMENT_DEGREEOFESTABLISHMENT_STANDARDIZED #276

ArthurChapman opened this issue Feb 8, 2024 · 18 comments
Labels
Amendment Conformance CORE TG2 CORE tests OTHER Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 VOCABULARY

Comments

@ArthurChapman
Copy link
Collaborator

ArthurChapman commented Feb 8, 2024

TestField Value
GUID 74ef1034-e289-4596-b5b0-cde73796697d
Label AMENDMENT_DEGREEOFESTABLISHMENT_STANDARDIZED
Description Proposes an amendment to the value of dwc:degreeOfEstablishment using the bdq:sourceAuthority.
TestType Amendment
Darwin Core Class dwc:Occurrence
Information Elements ActedUpon dwc:degreeOfEstablishment
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:degreeOfEstablishment is bdq:Empty; AMENDED the value of dwc:degreeOfEstablishment if it can be unambiguously matched to a term in the bdq:sourceAuthority; otherwise NOT_AMENDED
Data Quality Dimension Conformance
Term-Actions DEGREEOFESTABLISHMENT_STANDARDIZED
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]}
Specification Last Updated 2024-04-16
Examples [dwc:degreeOfEstablishment="capt.": Response.status=AMENDED, Response.result=dwc:degreeOfEstablishment="captive", Response.comment="dwc:degreeOfEstablishment contains an interpretable value in the bdq:sourceAuthority"]
[dwc:degreeOfEstablishment="tree": Response.status=NOT_AMENDED, Response.result="", Response.comment="dwc:degreeOfEstablishment does not contain an interpretable value in the bdq:sourceAuthority"]
Source TG2
References
  • Darwin Core Maintenance Group (2021) Degree Of Establishment Controlled Vocabulary List of Terms. Biodiversity Information Standards (TDWG). http://rs.tdwg.org/dwc/doc/doe/
  • Groom et al. (2019) Improving Darwin Core for research and management of alien species. Biodiversity Information Science and Services 3: e38084. https://doi.org/10.3897/biss.3.38084
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes For reference, synonyms for values of dwc:degreeOfEstablishment can be found at https://registry.gbif.org/vocabulary/DegreeOfEstablishment/concepts.
@ArthurChapman ArthurChapman added TG2 Amendment OTHER Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT VOCABULARY Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Conformance Parameterized Test requires a parameter labels Feb 8, 2024
@ArthurChapman
Copy link
Collaborator Author

Should be made CORE - see comments under #268

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 9, 2024

Removed Notes on Supplementary.

@Tasilee Tasilee added CORE TG2 CORE tests and removed Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. labels Feb 9, 2024
@ArthurChapman
Copy link
Collaborator Author

See my comment #285 (comment) under #285. I agree that this test should be CORE, but should include a note that it is expected that most results would return a INTERNAL_PREREQUISITES_NOT_MET result.

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 19, 2024

Are tests like #285, #278 and this test address the needs of a specific community and would therefore not fit the CORE requirement of "widely applicable"?

@chicoreus
Copy link
Collaborator

chicoreus commented Feb 19, 2024 via email

@ArthurChapman
Copy link
Collaborator Author

This (along with Pathway) has a major Use Case as set out in Groom et al. and is increasing being used in the Invasive Species community. Invasive Species are a big issue around the world and are one of the Key Issues in the Biodiversity Convention. So definitely "Widely applicable" These terms have not long been included in Darwin Core, but now that they are there is a large coordinated user community beginning to use them. This community is not specific as under the Convention on Biological Diversity, most countries and governments around the world are required to work on this issue. I would strongly push for CORE as I see no reason to exclude them as the test is well written and there are suitable Vocabularies and API.

@chicoreus - I have no idea what "mature" is - this should be CORE - there is a defined Use Case.

@chicoreus
Copy link
Collaborator

Source authority should be:

bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/]}

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 24, 2024

I agree @chicoreus - changing Source Authority from

bdq:sourceAuthority default = "Darwin Core degreeOfEstablishment" {[https://dwc.tdwg.org/list/#dwc_degreeOfEstablishment]} {dwc:degreeOfEstablishment vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]}

to

bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/]}

@Tasilee
Copy link
Collaborator

Tasilee commented Mar 19, 2024

Should the Source Authority (API) be "https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts"?

@tucotuco
Copy link
Member

I think https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts is OK as a source authority because it actually has an API, as long as it is understood that the actually vocabulary is maintained at https://dwc.tdwg.org/doe/ and the GBIF API is expected to remain up to date with that.

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 16, 2024

Fixed syntax on INTERNAL_PREREQUISITES_NOT_NET in Expected Response.

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 16, 2024

Changed Source Authority from

bdq:sourceAuthority default = "Darwin Core degreeOfEstablishment" {[https://dwc.tdwg.org/list/#dwc_degreeOfEstablishment]} {dwc:degreeOfEstablishment vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]}

to

bdq:sourceAuthority default = "GBIF DegreeOfEstablishment Vocabulary" [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment]} {"dwc:degreeOfEstablishment vocabulary API" [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]}

@tucotuco
Copy link
Member

Source Authority should be

bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 16, 2024

Changed Source Authority from

bdq:sourceAuthority default = "GBIF DegreeOfEstablishment Vocabulary" [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment]} {"dwc:degreeOfEstablishment vocabulary API" [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]}

to

bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

@tucotuco
Copy link
Member

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 17, 2024

Corrected.

@chicoreus
Copy link
Collaborator

See #275 (comment)

The GBIF API is only of partial help here, it does not provide the actual Controlled Values from the TDWG vocabulary, the values it has differ in case, implementations can use the GBIF API for its additional values, but need to align the case to match the actual Controlled Value from the TDWG vocabulary for the dwc: term values (GBIF API is sufficient for the dwciri term values).

@Tasilee
Copy link
Collaborator

Tasilee commented May 14, 2024

GBIF vocabulary has now been aligned with Darwin Core. Thanks @timrobertson100

chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Jul 27, 2024
…, added to unit tests. Added implementations for core tests tdwg/bdq#284 tdwg/bdq#275 and tdwg/bdq#276 along with default methods and unit tests.
chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Aug 21, 2024
…#276 and tdwg/bdq#278 to recognized variants of controlled vocabulary terms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Amendment Conformance CORE TG2 CORE tests OTHER Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 VOCABULARY
Projects
None yet
Development

No branches or pull requests

4 participants