Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 integration tests in Scala folder are failing with non default HTTP clients. #49

Open
nstdio opened this issue Jan 27, 2019 · 1 comment

Comments

@nstdio
Copy link
Contributor

nstdio commented Jan 27, 2019

If we are changing httpClient in the TrelloTestFactory to AsyncTrelloHttpClient, AsyncTrelloHttpClient2 or RestTemplateHttpClient 3 integration tests are failing with following output.

./gradlew clean build

> Task :compileJava
warning: [options] bootstrap class path not set in conjunction with -source 1.7
1 warning

> Task :compileTestScala
Pruning sources from previous analysis, due to incompatible CompileSetup.
warning: [options] bootstrap class path not set in conjunction with -source 1.7
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 warning

> Task :test

com.julienvey.trello.CardIt > create API gets user-friendly error when list id unknown FAILED
    org.scalatest.exceptions.TestFailedException at CardIt.scala:21
        Caused by: com.julienvey.trello.exception.TrelloHttpException at CardIt.scala:22
            Caused by: java.util.concurrent.ExecutionException at CardIt.scala:22
                Caused by: com.fasterxml.jackson.core.JsonParseException

com.julienvey.trello.CardIt > create API gets proper exception and a user-friendly error with valid but inaccessible List Id FAILED
    org.scalatest.exceptions.TestFailedException at CardIt.scala:28
        Caused by: com.julienvey.trello.exception.TrelloHttpException at CardIt.scala:32
            Caused by: java.util.concurrent.ExecutionException at CardIt.scala:32
                Caused by: com.fasterxml.jackson.core.JsonParseException

com.julienvey.trello.CardIt > update API gets user-friendly exception when updating a deleted card FAILED
    org.scalatest.exceptions.TestFailedException at CardIt.scala:59
        Caused by: com.julienvey.trello.exception.TrelloHttpException at CardIt.scala:64
            Caused by: java.util.concurrent.ExecutionException at CardIt.scala:64
                Caused by: com.fasterxml.jackson.core.JsonParseException

223 tests completed, 3 failed

As a solution for this kind of problems I could try to implement parametrized tests and integrate Travis for project.

@alexeyOnGitHub
Copy link
Member

using all clients in the new Scala-based integration tests sounds like a good idea.
the old Java-based tests follow this approach.

@alexeyOnGitHub alexeyOnGitHub changed the title 3 Tests are failing with non default HTTP clients. 3 integration tests in Scala folder are failing with non default HTTP clients. Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants