Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert pipeline images from shell scripts to Go binaries #122

Open
richcooper95 opened this issue May 10, 2024 · 2 comments
Open
Labels

Comments

@richcooper95
Copy link
Member

We have a couple of binaries that we run in Pipelines: reader and update-status. These are currently just shell scripts, but because of this, they're not very testable.

Currently, they're only covered in our system tests, which can't/shouldn't cover every edge case, so some testing is missing (and issues like #118 can occur).

This issue is to rewrite the scripts in Go, and add some unit tests, to ensure test coverage of these scripts.

(Note: There may be more scripts that we could convert too - reader and update-status are the two which seem most important, but if you find others, either raise a new issue or convert them as part of this issue depending on how big they are!)

@SaphMB
Copy link
Member

SaphMB commented May 22, 2024

@kirederik
Copy link
Member

another bug on the shell script that could be more easily be fixed/picked up by a golang binary #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants