[make:security:form-login] no interaction for make:security:form-login #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eltharin
force-pushed
the
NonInteractive_formlogin
branch
2 times, most recently
from
c7c8f6a
to
9529eda
Compare
eltharin
force-pushed
the
NonInteractive_formlogin
branch
from
9529eda
to
46c1f55
Compare
eltharin
changed the title
jrushlow
requested changes
Sep 25, 2024
Comment on lines
-60
to
-64
| private string $controllerName; | ||
| private string $firewallToUpdate; | ||
| private string $userClass; | ||
| private string $userNameField; | ||
| private bool $willLogout; |
There was a problem hiding this comment.
We need to keep both of these properties. MakerBundle is getting away from "abusing" setArgument and getArgument for the purposes of passing user input from one method to the next within a maker command. e.g. separation of concerns.
tl;dr interact() configures and sets any values onto their respective properties that will later be needed in generate()
interact() should get, validate, and set input.
generate() should only use values that are set via class properties when possible.
Comment on lines
-127
to
-131
| $securityHelper = new InteractiveSecurityHelper(); | ||
| $this->firewallToUpdate = $securityHelper->guessFirewallName($io, $securityData); | ||
| $this->userClass = $securityHelper->guessUserClass($io, $securityData['security']['providers']); | ||
| $this->userNameField = $securityHelper->guessUserNameField($io, $this->userClass, $securityData['security']['providers']); | ||
| $this->willLogout = $io->confirm('Do you want to generate a \'/logout\' URL?'); |
There was a problem hiding this comment.
Following on from the above, these all need to stay in interact. They should not be set in the generate method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow command make:security:form-login with name in argument to no interaction
as help says : make:security:form-login [<controllerName>]