wip - use the new bundle structure #1514
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing to see here yet...
see - symfony/symfony-docs#19793
I'm not sure if we should do this yet... Maker has a "leg up" on the other
symfony/*
bundles because we're a bit bleeding edge. Our minimumsymfony/*
is6.4
- but by merging this PR, we would be breaking away from say,FrameworkBundle
that still uses the legacyBundle
class...On the flip side, if we do press forward with this PR - we could reference this change somehow in the docs to show others how we "converted" to the new simplification strategy.
Pinging @nicolas-grekas @javiereguiluz & @yceruto This isn't review ready yet, but feedback on if we should press forward with this would be awesome.
Merge blockers:
src/DependencyInjection/CompilerPass/*
figure out if these should live here still - or if there is a better way...src/Resources/bin
- This is our "bundled" php-cs-fixer, it needs a new home (not intended to be directly called by the user...)src/Resources/config/php-cs-fixer.config.php
- used by our internal php-cs-fixer when runningmake:*
- make sure this path isnt hard coded.. If it is, fix it to use the newconfig/php-cs-fixer.config.php
path.src/Resources/doc
->doc/
src/Resources/help
- figure out a home for these files - theAbstractMaker
? (or another parent class) needs to be updated to point the command to the new help locationsrc/Resources/Skeleton
- our "templates" need a new home. These feel like they should live insrc
maybe something likesrc/Skeleton
? hmm....