Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support for v2 deposits and executions #184

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: Support for v2 deposits and executions #184

wants to merge 10 commits into from

Conversation

mj52951
Copy link
Contributor

@mj52951 mj52951 commented Mar 5, 2024 •
edited
Loading

Added support for v2 deposits by storing securityModel to the database and removing handlerResponse.
When securityModel isn't defined it is set to the default value of 1.

closes sygmaprotocol/squid-indexer#2

Also, updated support for v2 executions by removing redundant dataHash parameter and decodeDataHash function.

closes sygmaprotocol/squid-indexer#3
closes sygmaprotocol/squid-indexer#4

@mj52951 mj52951 marked this pull request as ready for review March 7, 2024 09:45
@mj52951 mj52951 changed the title feat: Support for v2 deposits feat: Support for v2 deposits and executions Mar 7, 2024
MakMuftic
MakMuftic requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@MakMuftic MakMuftic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to bring up changes here for listening on 2 different bridge addresses in parallel. One representing original MPC setup, and second representing new Spectre setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic MakMuftic requested changes

@tcar121293 tcar121293 Awaiting requested review from tcar121293

@wainola wainola Awaiting requested review from wainola

@mpetrun5 mpetrun5 Awaiting requested review from mpetrun5

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support V2 fees Support indexing for V2 executions Support indexing for V2 deposits
2 participants
@mj52951 @MakMuftic