Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify some input logic #8317

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Nefsen402
Copy link
Member

@Nefsen402 Nefsen402 commented Aug 26, 2024

Goals:

  1. Get rid of toplevel_layer_surface_from_surface(). We can just walk the scene to get this info.
  2. Introduce a few scene descriptor helpers to reduce code duplication

See individual commits.

We'll want to use the descriptor type for a helper soon and we don't want
to pull all of view.h with us.
Same as the assign variant, but lets us mutate an existing descriptor
if it exists instead of asserting.
We have to do with for fullscreen surfaces: Fullscreen surfaces
technically aren't part of their container anymore visually (so the
scene doesn't have it) but we want acknowledge the container it belongs
to for input reasons.

This will allow us to simplify node_at_coords later.
…escriptor_find

We can instead search the scene instead of hand rolling this logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant