Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring ideas #99

Open
7 of 12 tasks
DeD1rk opened this issue Aug 21, 2021 · 2 comments
Open
7 of 12 tasks

Refactoring ideas #99

DeD1rk opened this issue Aug 21, 2021 · 2 comments
Labels
chore Something that is not a bug or a feature, does not change production behaviour priority: low Should be dealt with when nothing else remains.

Comments

@DeD1rk
Copy link
Member

DeD1rk commented Aug 21, 2021

This issue lists some proposed ideas for refactoring:

  • Make AuthBloc a cubit.
  • Make ThemeBloc a cubit.
  • Combine RegistrationsCubit into EventCubit.
  • Create a Page subclass for each screen, that specifies the name, arguments and optionally transition animations.
  • Replace ApiException enum by a class(-tree) that may contain a string.
  • Move expensive JSON parsing into isolates.
  • Move the CalendarCubit's expensive operations into isolates.
  • Simplify exception handling in ApiRepository.
  • Outline url handling to a utility function (mainly HtmlWidget.onTapUrl)
  • Change to StatelessWidget wherever possible
  • Make a common qubit for liststates since most of the code can be almost identical #444
  • Use typed routes where possible

These may not all be useful or necessary.

@DeD1rk DeD1rk added chore Something that is not a bug or a feature, does not change production behaviour priority: low Should be dealt with when nothing else remains. labels Aug 21, 2021
@se-bastiaan
Copy link
Contributor

  • Use classes for all SearchDelegate implementations to prevent code duplication

@DeD1rk
Copy link
Member Author

DeD1rk commented Oct 11, 2021

  • Use classes for all SearchDelegate implementations to prevent code duplication
    Good one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that is not a bug or a feature, does not change production behaviour priority: low Should be dealt with when nothing else remains.
Projects
None yet
Development

No branches or pull requests

2 participants