Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rough in a Bridgetown scanner #3962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rough in a Bridgetown scanner #3962

wants to merge 1 commit into from

Conversation

rubys
Copy link
Contributor

@rubys rubys commented Sep 26, 2024

Based on: https://www.bridgetownrb.com/docs/deployment#dynamic-site

Ideas for future improvements in the Dockerfile:

  • image size could be reduced by moving build-essential to the "gem" step
  • COPY --from=base is unnecessary when preceeded by FROM base
  • Moving yarn install to before COPY . . and after a new COPY package.json . would make yarn install only be run when package.json changes.
  • Moving yarn install to a separate build step would enable yarn install and gem install to be run concurrently

Based on: https://www.bridgetownrb.com/docs/deployment#dynamic-site

Ideas for future improvements in the Dockerfile:
  * image size could be reduced by moving build-essential to the "gem" step
  * COPY --from=base is unnecessary when preceeded by FROM base
  * Moving yarn install to before COPY . . and after a new COPY package.json .
    would make yarn install only be run when package.json changes.
  * Moving yarn install to a separate build step would enable yarn install
    and gem install to be run concurrently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant