Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BL7 upgrade: OSD control buttons not rendering #1474

Closed
camillevilla opened this issue Jan 14, 2020 · 2 comments
Closed

BL7 upgrade: OSD control buttons not rendering #1474

camillevilla opened this issue Jan 14, 2020 · 2 comments
Assignees
@mejackreed

Comments

@camillevilla
Copy link
Contributor

camillevilla commented Jan 14, 2020 •
edited
Loading

Part of #1473

To recreate:
Curation > Items > Add item > Upload item > Item page

Before upgrade

Screen Shot 2020-01-14 at 3 36 32 PM

After upgrade

Rendering XML instead of buttons
@mejackreed
Copy link
Contributor

Are we moving to sul-embed for this type of display at some point? (I can't remember)

@camillevilla
Copy link
Contributor Author

@mejackreed that's the hope in #1439 but we're blocked until we can find a clever workaround for the CORBs stuff.

@mejackreed mejackreed self-assigned this Jan 15, 2020
@mejackreed mejackreed mentioned this issue Jan 15, 2020
Merged
@cbeer cbeer closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mejackreed mejackreed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cbeer @mejackreed @camillevilla