-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update-version.sh changing all files #21
Comments
I agree. Internally I am using a blacklist of files to avoid
But I think instead we should only give a whiltelist of files to modify. |
Is there really a use case of having version in files other main php and README files ? We need to match patterns likes Version: or Stable Tag: . Search and replace is dangerous, no matter how many files we exclude. It would be really good if everything happened in one command: ~/wp-plugin-in-github/deploy-plugin.sh -m If
else
|
One use case is that I include the version of the plugin in a constant. Other plugin authors also include the version as query string in wp_enqueue_scripts/styles functions.
I agree. That's why I do a
I don't want to force people to use Also I use this script in my non-WordPress projects as well and would prefer to keep it as a seperate script instead of merging it with |
The text was updated successfully, but these errors were encountered: