Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement optimized constraints for keccak256 #114

Open
puma314 opened this issue Aug 31, 2023 · 2 comments
Open

Implement optimized constraints for keccak256 #114

puma314 opened this issue Aug 31, 2023 · 2 comments
Labels
medium Open-Source Program

Comments

@puma314
Copy link
Contributor

puma314 commented Aug 31, 2023

We currently have an implementation of keccack256 that needs implementation of optimized constraints: https://github.com/succinctlabs/succinctx/blob/main/plonky2x/src/frontend/hash/keccak/mod.rs#L13.

The implementation should be quite similar to this implementation of sha256: https://github.com/succinctlabs/succinctx/blob/main/plonky2x/src/frontend/hash/sha/sha256.rs.
@nullity00
Copy link

I would like to take up this issue. And, I have a few questions :

  1. I found two implementations of keccak256, one in circom by Vocdoni & another in plonky2 by JumpCrypto. Which one would you recommend following ? Or do you recommend referring any other implementations ?
  2. Found this task implemented here. Are there any hidden caveats that I should be aware of if I am going to take this up ?

@puma314
Copy link
Contributor Author

puma314 commented Oct 24, 2023

We have 2 closed PRs that made some progress on this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
medium Open-Source Program
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@puma314 @nullity00