From 8ae1084761c0c384c9c54bd4d7af62c4a58ea1cc Mon Sep 17 00:00:00 2001
From: Arttu <Blizzara@users.noreply.github.com>
Date: Wed, 21 Aug 2024 14:06:25 +0200
Subject: [PATCH] fix: correct format for nullable interval_day parameters
 (#687)

Fixes a bug in `functions_datetime.yaml` that makes it un-parseable by
substrait-java, introduced in #679. The `?` for nullability must come
before the parameters:
https://substrait.io/types/type_parsing/#type-syntax-parsing
---
 extensions/functions_datetime.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/extensions/functions_datetime.yaml b/extensions/functions_datetime.yaml
index 28c97c802..5847c276c 100644
--- a/extensions/functions_datetime.yaml
+++ b/extensions/functions_datetime.yaml
@@ -1047,8 +1047,8 @@ aggregate_functions:
             value: interval_day<P>
         nullability: DECLARED_OUTPUT
         decomposable: MANY
-        intermediate: interval_day<P>?
-        return: interval_day<P>?
+        intermediate: interval_day?<P>
+        return: interval_day?<P>
       - args:
           - name: x
             value: interval_year
@@ -1099,8 +1099,8 @@ aggregate_functions:
             value: interval_day<P>
         nullability: DECLARED_OUTPUT
         decomposable: MANY
-        intermediate: interval_day<P>?
-        return: interval_day<P>?
+        intermediate: interval_day?<P>
+        return: interval_day?<P>
       - args:
           - name: x
             value: interval_year