Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add issn field #1354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add issn field #1354

wants to merge 1 commit into from

Conversation

malayibiri
Copy link

Why

ISSN field is needed in JournalArticleRef.

What

I just add ISSN field like ISBN in Books.
Also in convertCSLJSON allow import CSLJSON files without DOIs, what are the problems in the further processing? everything seems to work ok in my local copy.

@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #1354 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
+ Coverage   86.53%   86.53%   +<.01%     
==========================================
  Files         387      387              
  Lines        7426     7428       +2     
==========================================
+ Hits         6426     6428       +2     
  Misses       1000     1000
Impacted Files Coverage Δ
src/article/converter/bib/BibConversion.js 80.55% <ø> (ø) ⬆️
src/article/nodes/JournalArticleRef.js 100% <ø> (ø) ⬆️
src/article/shared/EntityLabelsPackage.js 100% <100%> (ø) ⬆️
...article/converter/jats/ElementCitationConverter.js 95.72% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9652776...b3038bc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant