Various fixes & improvements #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will hopefully simplify setup for potential newcomers once frontend is introduced as well. Signed-off-by: František Nečas <[email protected]>
The dist directory must be present, otherwise ASP .NET Core throws an error. Upon first cloning the repository, it is not present, create at least an empty directory (it will later be filled by angular builds). Signed-off-by: František Nečas <[email protected]>
Signed-off-by: František Nečas <[email protected]>
Get rid of pointless documentation from school projects, rewrite README to English, add instructions for running inside containers. Signed-off-by: František Nečas <[email protected]>
The behaviour of the lookahead is a bit buggy in some browsers on mobile causing it to query the formatted result again once it's selected resulting in an error. Editing the chosen user does not make sense (and resets the model), hence it's better to make the field readonly after selection anyway and allow resetting it. Signed-off-by: František Nečas <[email protected]>
Signed-off-by: František Nečas <[email protected]>
This makes it more clear that the toast can be dismissed (by tapping anywhere, not just the button) which should allow the user to faster get back to using the app when a toast is blocking view of an important element (e.g. login button blocked by toast mentioning that login has expired). Signed-off-by: František Nečas <[email protected]>
Signed-off-by: František Nečas <[email protected]>
The users (even if not logged in) should know whether the board game is available in the club. For this reason, add a label mentioning unavailability instead of the typical reservation button for such users. Signed-off-by: František Nečas <[email protected]>
The new ordering is as follows: 1) events 2) current/upcoming states 3) past states In each of these categories, the elements are ordered chronologically based on start time. This is to make the most important things the closests to the top. Signed-off-by: František Nečas <[email protected]>
This was
linked to
issues
Sep 1, 2022
Signed-off-by: František Nečas <[email protected]>
|
Merged; however, I removed 2ed5bd5 because I don't think it was a great solution. |
This was referenced Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a lot of small fixes and improvements and due to #122 still not being merged, I am putting everything together into this one PR targetting the
frnecas-dockerbranch (I wanted to experiment with the new setup while developing :) ). I will rebase/change targets based on the order of merging.Fixes: #121
Fixes: #109 (well, kinda differently than previously anticipated, but it should now be more apparent that the modal can be closed)
Fixes: #108
Fixes: #103
Fixes: #120
Fixes: #125
Also fixes the user select bug mentioned on Discord