Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Improve date handling of announcements #300

Open
AlexCPU opened this issue Oct 12, 2021 · 0 comments
Open

Feature: Improve date handling of announcements #300

AlexCPU opened this issue Oct 12, 2021 · 0 comments
Assignees
@ussjohnjay
Labels
enhancement New feature or request

Comments

@AlexCPU
Copy link
Contributor

AlexCPU commented Oct 12, 2021

Thinking about how we're likely to use announcements, I'd expect any PR making visible changes to include a new announcement file explaining the changes, so the users are informed.

We need some way of making that announcement stay visible for 3 days after the PR is merged, rather than the date that the code is committed. Obviously I could push a commit to update the date before merging the changes, but something automatic would be nice.
@AlexCPU AlexCPU added the enhancement New feature or request label Oct 12, 2021
ussjohnjay added a commit that referenced this issue Oct 20, 2021
@ussjohnjay
Announcements page with dismissal and excerpts
d38d35a 
More fully-featured version of the announcements function introduced last week.

This sets up an announcements page that lists the 20 most recent announcements at datacore.app/announcements. Announcements can now link excerpts on the index page to the announcements page for more details. An amended version of the new voyage calc announcement demos this.

Announcements on the index page can now be dismissed. Otherwise announcements will expire 7 days after the post date. Resolves #299.

I have yet to figure out an easy way to handle #300. Any suggestions would be welcome!

This separates the announcements functions to their own page and component. Also fixes the unintentional "feature" of creating pages for each individual announcement.
@ussjohnjay ussjohnjay mentioned this issue Oct 20, 2021
Merged
joshurtree pushed a commit that referenced this issue Oct 21, 2021
@ussjohnjay @joshurtree
Announcements page with dismissal and excerpts
fdd7695 
More fully-featured version of the announcements function introduced last week.

This sets up an announcements page that lists the 20 most recent announcements at datacore.app/announcements. Announcements can now link excerpts on the index page to the announcements page for more details. An amended version of the new voyage calc announcement demos this.

Announcements on the index page can now be dismissed. Otherwise announcements will expire 7 days after the post date. Resolves #299.

I have yet to figure out an easy way to handle #300. Any suggestions would be welcome!

This separates the announcements functions to their own page and component. Also fixes the unintentional "feature" of creating pages for each individual announcement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ussjohnjay ussjohnjay

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexCPU @ussjohnjay